Add systeminfo.storage API implementation skeleton

chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.h

Index: chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.h
diff --git a/chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.h b/chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.h
new file mode 100644
index 0000000000000000000000000000000000000000..620c597e9b7c280a8a1dbbeb94dde596278865e5
--- /dev/null
+++ b/chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.h
@@ -0,0 +1,24 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef CHROME_BROWSER_EXTENSIONS_API_SYSTEMINFO_STORAGE_SYSTEMINFO_STORAGE_API_H_
+#define CHROME_BROWSER_EXTENSIONS_API_SYSTEMINFO_STORAGE_SYSTEMINFO_STORAGE_API_H_
+
+#include "chrome/browser/extensions/extension_function.h"
+
+namespace extensions {
+
+class SysteminfoStorageGetFunction : public AsyncExtensionFunction {

[James Hawkins, 2012/08/09 15:47:34]

nit: Document class.

+ public:
+  DECLARE_EXTENSION_FUNCTION_NAME("experimental.systeminfo.storage.get");
+  SysteminfoStorageGetFunction();
+  virtual ~SysteminfoStorageGetFunction();
+ protected:

[James Hawkins, 2012/08/09 15:47:34]

nit: Blank line between access sections.

[James Hawkins, 2012/08/09 15:47:34]

Why do these need to be protected as opposed to private?

[Hongbo Min, 2012/08/10 02:43:29]

Actually, there is no criteria for it.

Just going through the source code of extension api implementation, take RunImpl
for example, some of them are declared as public, and some are protected, and
some are private.

On 2012/08/09 15:47:34, James Hawkins wrote:

[James Hawkins, 2012/08/11 16:37:54]

Review process nit: Please bottom-post review replies.  I'll top-post on this
one so it remains semi-readable.

Please use the most limited access possible, which could mean private here.

On 2012/08/10 02:43:29, Hongbo wrote:

+  virtual bool RunImpl() OVERRIDE;

[James Hawkins, 2012/08/09 15:47:34]

nit: // AsyncExtensionFunction implementation.

+  void WorkOnFileThread();

[James Hawkins, 2012/08/09 15:47:34]

nit: Document these methods.

+  void RespondOnUIThread(bool success);
+};
+
+} // namespace extensions

[James Hawkins, 2012/08/09 15:47:34]

nit: Two spaces before comment.

+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_SYSTEMINFO_STORAGE_SYSTEMINFO_STORAGE_API_H_