chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.h - Issue 10824232: Add systeminfo.storage API implementation skeleton

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.h

Issue 10824232: Add systeminfo.storage API implementation skeleton (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/systeminfo_storage/storage_info_provider.h ('K') | « chrome/browser/extensions/api/systeminfo_storage/storage_info_provider_win.cc ('k') | chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.cc » ('j') | chrome/browser/extensions/api/systeminfo_storage/systeminfo_storage_api.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef CHROME_BROWSER_EXTENSIONS_API_SYSTEMINFO_STORAGE_SYSTEMINFO_STORAGE_API_ H_

	5 #define CHROME_BROWSER_EXTENSIONS_API_SYSTEMINFO_STORAGE_SYSTEMINFO_STORAGE_API_ H_

	6

	7 #include "chrome/browser/extensions/extension_function.h"

	8

	9 namespace extensions {

	10

	11 class SysteminfoStorageGetFunction : public AsyncExtensionFunction {
	James Hawkins 2012/08/09 15:47:34 nit: Document class. nit: Document class.
	12 public:

	13 DECLARE_EXTENSION_FUNCTION_NAME("experimental.systeminfo.storage.get");

	14 SysteminfoStorageGetFunction();

	15 virtual ~SysteminfoStorageGetFunction();

	16 protected:
	James Hawkins 2012/08/09 15:47:34 nit: Blank line between access sections. nit: Blank line between access sections. James Hawkins 2012/08/09 15:47:34 Why do these need to be protected as opposed to pr Why do these need to be protected as opposed to private? Hongbo Min 2012/08/10 02:43:29 Actually, there is no criteria for it. Just going Actually, there is no criteria for it. Just going through the source code of extension api implementation, take RunImpl for example, some of them are declared as public, and some are protected, and some are private. On 2012/08/09 15:47:34, James Hawkins wrote: Show quoted text > Why do these need to be protected as opposed to private? James Hawkins 2012/08/11 16:37:54 Review process nit: Please bottom-post review repl Review process nit: Please bottom-post review replies. I'll top-post on this one so it remains semi-readable. Please use the most limited access possible, which could mean private here. On 2012/08/10 02:43:29, Hongbo wrote: Show quoted text > Actually, there is no criteria for it. > > Just going through the source code of extension api implementation, take RunImpl > for example, some of them are declared as public, and some are protected, and > some are private. > > On 2012/08/09 15:47:34, James Hawkins wrote: > > Why do these need to be protected as opposed to private? >
	17 virtual bool RunImpl() OVERRIDE;
	James Hawkins 2012/08/09 15:47:34 nit: // AsyncExtensionFunction implementation. nit: // AsyncExtensionFunction implementation.
	18 void WorkOnFileThread();
	James Hawkins 2012/08/09 15:47:34 nit: Document these methods. nit: Document these methods.
	19 void RespondOnUIThread(bool success);

	20 };

	21

	22 } // namespace extensions
	James Hawkins 2012/08/09 15:47:34 nit: Two spaces before comment. nit: Two spaces before comment.
	23

	24 #endif // CHROME_BROWSER_EXTENSIONS_API_SYSTEMINFO_STORAGE_SYSTEMINFO_STORAGE_A PI_H_

OLD	NEW