Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 10824208: Fix logic for VPN badges and network menu order (Closed)

Created:
8 years, 4 months ago by stevenjb
Modified:
8 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix logic for VPN badges and network menu order There were a few bugs, and some confusing UI. I made the following changes: * Moved the ShouldShowIconInTray() logic into NetworkMenuIcon. * Removed the unused function GetVpnImage() * Made VPN icon code similar to other network types * Changed network display order to: ** Active network ** Connected networks (VPN, Ethernet, Cellular, Wimax, Wifi) ** Unconnected networks (same order) BUG=137941 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150607

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -215 lines) Patch
M chrome/browser/chromeos/cros/network_library_impl_stub.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.cc View 20 chunks +84 lines, -76 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 6 chunks +132 lines, -130 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
stevenjb
P1 for M22, ready for review when you have a chance.
8 years, 4 months ago (2012-08-07 21:57:19 UTC) #1
sadrul
8 years, 4 months ago (2012-08-08 14:59:20 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698