Issue 10824177: Reapply "Added support for copied parameters to the SSA compiler."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824177: Reapply "Added support for copied parameters to the SSA compiler." (Closed)

Created:
8 years, 4 months ago by zerny-google

Modified:
8 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Added support for copied parameters to the SSA compiler." This reapplies svn revision 10172 with a bug fix. Original Review URL: https://chromiumcodereview.appspot.com//10837076 R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10280

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -24 lines)			Patch
M	runtime/vm/flow_graph_allocator.cc	View	2 chunks	+13 lines, -2 lines	1 comment	Download
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	5 chunks	+29 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zerny-google

http://codereview.chromium.org/10824177/diff/1/runtime/vm/flow_graph_allocator.cc File runtime/vm/flow_graph_allocator.cc (right): http://codereview.chromium.org/10824177/diff/1/runtime/vm/flow_graph_allocator.cc#newcode477 runtime/vm/flow_graph_allocator.cc:477: spill_slots_.Add(range->End()); This has to come before splitting. This is ...

8 years, 4 months ago (2012-08-06 09:39:52 UTC) #1

LGTM.

Expand Messages | Collapse Messages