remoting/base/breakpad_win.cc - Issue 10824166: Cleaned up usage of std::wstring in src/remoting. Added presubmit warning supressions for the reman…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/base/breakpad_win.cc

Issue 10824166: Cleaned up usage of std::wstring in src/remoting. Added presubmit warning supressions for the reman… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR feedback Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/base/breakpad_win.cc

diff --git a/remoting/base/breakpad_win.cc b/remoting/base/breakpad_win.cc

index 05f1866524a77c7157bbffe8dd176ee0efd83f5f..d9ca087faaa8adb8e7da3558cdb11c39e2eaa86b 100644

--- a/remoting/base/breakpad_win.cc

+++ b/remoting/base/breakpad_win.cc

@@ -153,6 +153,7 @@ google_breakpad::CustomClientInfo* BreakpadWin::GetCustomInfo() {

scoped_ptr<FileVersionInfo> version_info(

FileVersionInfo::CreateFileVersionInfoForModule(binary));

+ // presubmit: allow wstring

std::wstring version;

if (version_info.get())

version = UTF16ToWide(version_info->product_version());

Wez 2012/08/06 18:33:18 Here.

alexeypa (please no reviews) 2012/08/06 19:31:54 UTF16ToWide is used here because CustomInfoEntry r

« no previous file with comments | « PRESUBMIT.py ('k') | remoting/host/host_event_logger_win.cc » ('j') | remoting/host/plugin/daemon_installer_win.cc » ('J')