Cleaned up usage of std::wstring in src/remoting. Added presubmit warning supressions for the reman…

remoting/base/breakpad_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module contains the necessary code to register the Breakpad exception
 // handler. This implementation is based on Chrome/Chrome Frame crash reporting
 // code. See:
 //   - src/chrome/app/breakpad_win.cc
 //   - src/chrome_frame/crash_server_init.cc
 //   - src/chrome/installer/setup/setup_main.cc
@@ skipping 135 matching lines @@
   return &g_instance.Get();
 }
 
 // Returns the Custom information to be used for crash reporting.
 google_breakpad::CustomClientInfo* BreakpadWin::GetCustomInfo() {
   HMODULE binary = base::GetModuleFromAddress(
       reinterpret_cast<void*>(&remoting::InitializeCrashReporting));
   scoped_ptr<FileVersionInfo> version_info(
       FileVersionInfo::CreateFileVersionInfoForModule(binary));
 
+  // presubmit: allow wstring
   std::wstring version;
   if (version_info.get())
     version = UTF16ToWide(version_info->product_version());

[Wez, 2012/08/06 18:33:18]

Here.

[alexeypa (please no reviews), 2012/08/06 19:31:54]

UTF16ToWide is used here because CustomInfoEntry requires a wide pointer while
product_version gives me a UTF-16 pointer.

But I see a different problem here: the returned |custon_info| should not point
to a buffer, allocated by wstring because it will be deleted once we leave the
scope.

   if (version.empty())
     version = kBreakpadVersionDefault;
 
   static google_breakpad::CustomInfoEntry ver_entry(
       kBreakpadVersionEntry, version.c_str());
   static google_breakpad::CustomInfoEntry prod_entry(
       kBreakpadProdEntry, kBreakpadProductName);
   static google_breakpad::CustomInfoEntry plat_entry(
       kBreakpadPlatformEntry, kBreakpadPlatformWin32);
   static google_breakpad::CustomInfoEntry entries[] = {
@@ skipping 35 matching lines @@
   // Touch the object to make sure it is initialized.
   BreakpadWin::GetInstance();
 }
 
 void InitializeCrashReportingForTest(const wchar_t* pipe_name) {
   BreakpadWin::pipe_name_ = pipe_name;
   InitializeCrashReporting();
 }
 
 }  // namespace remoting