Issue 10824147: Added support for copied parameters to the SSA compiler.

Issue 10824147: Added support for copied parameters to the SSA compiler. (Closed)

Created:
8 years, 4 months ago by zerny-google

Modified:
8 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added support for copied parameters to the SSA compiler. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10172

Patch Set 1 #

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -24 lines)			Patch
M	runtime/vm/flow_graph_allocator.cc	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	5 chunks	+29 lines, -21 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. http://codereview.chromium.org/10824147/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): http://codereview.chromium.org/10824147/diff/1/runtime/vm/flow_graph_builder.cc#newcode2262 runtime/vm/flow_graph_builder.cc:2262: // Either all parameters are fixed or (ie, ...

8 years, 4 months ago (2012-08-02 14:44:39 UTC) #2

Florian Schneider

http://codereview.chromium.org/10824147/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): http://codereview.chromium.org/10824147/diff/1/runtime/vm/flow_graph_builder.cc#newcode2262 runtime/vm/flow_graph_builder.cc:2262: // Either all parameters are fixed or (ie, one ...

8 years, 4 months ago (2012-08-02 14:45:58 UTC) #3

zerny-google

8 years, 4 months ago (2012-08-02 14:50:35 UTC) #4

http://codereview.chromium.org/10824147/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

http://codereview.chromium.org/10824147/diff/1/runtime/vm/flow_graph_builder....
runtime/vm/flow_graph_builder.cc:2262: // Either all parameters are fixed or
(ie, one is named) they are all copied.
On 2012/08/02 14:45:59, Florian Schneider wrote:
> On 2012/08/02 14:44:39, Florian Schneider wrote:
> > s/one/none/
> 
> Actually I'd write:
> 
> Either all parameters are fixed (none is named) or they are all copied.

Done.

Expand Messages | Collapse Messages