Issue 10824017: Implement deoptimization in the SSA compiler as a parallel move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824017: Implement deoptimization in the SSA compiler as a parallel move. (Closed)

Created:
8 years, 5 months ago by Kevin Millikin (Google)

Modified:
8 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement deoptimization in the SSA compiler as a parallel move. R=srdjan@google.com,vegorov@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9931

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -23 lines)			Patch
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+17 lines, -11 lines	1 comment	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+18 lines, -11 lines	1 comment	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

This turns the sequence of pushes into a sequence of moves and swaps, which will ...

8 years, 5 months ago (2012-07-25 15:51:35 UTC) #1

srdjan

LGTM, nice! http://codereview.chromium.org/10824017/diff/1/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): http://codereview.chromium.org/10824017/diff/1/runtime/vm/flow_graph_compiler_ia32.cc#newcode45 runtime/vm/flow_graph_compiler_ia32.cc:45: const int top_offset = s/int/intptr_t/

8 years, 5 months ago (2012-07-25 17:25:52 UTC) #2

Vyacheslav Egorov (Google)

8 years, 5 months ago (2012-07-26 12:59:56 UTC) #3

http://codereview.chromium.org/10824017/diff/1/runtime/vm/flow_graph_compiler...
File runtime/vm/flow_graph_compiler_x64.cc (right):

http://codereview.chromium.org/10824017/diff/1/runtime/vm/flow_graph_compiler...
runtime/vm/flow_graph_compiler_x64.cc:46: ParsedFunction::kFirstLocalSlotIndex -
values.length();
this should have been actually ParsedFunction::kFirstLocalSlotIndex -
(values.length() - 1)

Because if we have one local we should do Address(EBP, -2 * kWordSize) to get to
it. 

(yep it was incorrect initially as well).

Expand Messages | Collapse Messages