gdata: Change callback type of GDataDirectoryService::GetEntryInfoByResourceId()

chrome/browser/chromeos/gdata/gdata_test_util.h

Index: chrome/browser/chromeos/gdata/gdata_test_util.h
diff --git a/chrome/browser/chromeos/gdata/gdata_test_util.h b/chrome/browser/chromeos/gdata/gdata_test_util.h
index 75c4494f163cfefbf6ccbea7855f46679e0f7d8a..8bc4bdb55d813471636dd3044e3e1b9a3c7c3331 100644
--- a/chrome/browser/chromeos/gdata/gdata_test_util.h
+++ b/chrome/browser/chromeos/gdata/gdata_test_util.h
@@ -74,8 +74,20 @@ void CopyResultsFromReadDirectoryCallback(
     GDataFileError error,
     scoped_ptr<GDataEntryProtoVector> entries);
 
-// Copies |result| |out_result|. Used to run asynchronous functions that take
-// GetEntryInfoPairCallback from tests.
+// Copies |error|, |drive_file_path|, and |entry_proto| to |out_error|,
+// |out_drive_file_path|, and |out_entry_proto| respectively. Used to run
+// asynchronous functions that take GetEntryInfoWithFilePathCallback from
+// tests.
+void CopyResultsFromGetEntryInfoWithFilePathCallback(

[achuithb, 2012/08/20 23:19:09]

Do we really need this here? Why not put this in the anonymous scope of
gdata_directory_service_unittest.cc

It's harder to look up because of the lack of locality. 

There was also a discussion on chromium-dev to avoid util files because they
become a dumping ground.

The function bodies are so small and trivial that it's probably worthwhile to
just copy them in all the unit tests that they are used in. and get rid of this
file altogether.

But that's just my opinion. It's up to you to leave as is.

[satorux1, 2012/08/20 23:24:43]

I plan to use these Copy* functions from gdata_file_system_unittest.cc. As of
now, CallbackHelper class is used to copy results, but using these functions
would be cleaner. crbug.com/141521

+    GDataFileError* out_error,
+    FilePath* out_drive_file_path,
+    scoped_ptr<GDataEntryProto>* out_entry_proto,
+    GDataFileError error,
+    const FilePath& drive_file_path,
+    scoped_ptr<GDataEntryProto> entry_proto);
+
+// Copies |result| to |out_result|. Used to run asynchronous functions
+// that take GetEntryInfoPairCallback from tests.
 void CopyResultsFromGetEntryInfoPairCallback(
     scoped_ptr<EntryInfoPairResult>* out_result,
     scoped_ptr<EntryInfoPairResult> result);