gdata: Change callback type of GDataDirectoryService::GetEntryInfoByResourceId()

chrome/browser/chromeos/gdata/gdata_test_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_TEST_UTIL_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_TEST_UTIL_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/chromeos/gdata/gdata_directory_service.h"
 #include "chrome/browser/chromeos/gdata/gdata_errorcode.h"
@@ skipping 56 matching lines @@
 
 // Copies |error| and |entries| to |out_error| and |out_entries|
 // respectively. Used to run asynchronous functions that take
 // GetEntryInfoCallback from tests.
 void CopyResultsFromReadDirectoryCallback(
     GDataFileError* out_error,
     scoped_ptr<GDataEntryProtoVector>* out_entries,
     GDataFileError error,
     scoped_ptr<GDataEntryProtoVector> entries);
 
-// Copies |result| |out_result|. Used to run asynchronous functions that take
-// GetEntryInfoPairCallback from tests.
+// Copies |error|, |drive_file_path|, and |entry_proto| to |out_error|,
+// |out_drive_file_path|, and |out_entry_proto| respectively. Used to run
+// asynchronous functions that take GetEntryInfoWithFilePathCallback from
+// tests.
+void CopyResultsFromGetEntryInfoWithFilePathCallback(

[achuithb, 2012/08/20 23:19:09]

Do we really need this here? Why not put this in the anonymous scope of
gdata_directory_service_unittest.cc

It's harder to look up because of the lack of locality. 

There was also a discussion on chromium-dev to avoid util files because they
become a dumping ground.

The function bodies are so small and trivial that it's probably worthwhile to
just copy them in all the unit tests that they are used in. and get rid of this
file altogether.

But that's just my opinion. It's up to you to leave as is.

[satorux1, 2012/08/20 23:24:43]

I plan to use these Copy* functions from gdata_file_system_unittest.cc. As of
now, CallbackHelper class is used to copy results, but using these functions
would be cleaner. crbug.com/141521

+    GDataFileError* out_error,
+    FilePath* out_drive_file_path,
+    scoped_ptr<GDataEntryProto>* out_entry_proto,
+    GDataFileError error,
+    const FilePath& drive_file_path,
+    scoped_ptr<GDataEntryProto> entry_proto);
+
+// Copies |result| to |out_result|. Used to run asynchronous functions
+// that take GetEntryInfoPairCallback from tests.
 void CopyResultsFromGetEntryInfoPairCallback(
     scoped_ptr<EntryInfoPairResult>* out_result,
     scoped_ptr<EntryInfoPairResult> result);
 
 }  // namespace test_util
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_TEST_UTIL_H_