Re-factor system tray code controlling launcher visibility

Re-factor system tray code controlling launcher visibility

This CL prevents the launcher from being hidden when either the web notification tray or the system tray is visible.

BUG=142506
For minor change to ash/wm/shelf_layout_manager.cc:
TBR=sky@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152028

[stevenjb, 2012-08-15 21:50:34]

CL 2/3 for this issue, ready for review.

[sadrul, 2012-08-16 15:31:49]

LGTM with a couple of questions about the desired/implemented behaviour.

http://codereview.chromium.org/10823350/diff/12/ash/system/tray/system_tray.h
File ash/system/tray/system_tray.h (right):

http://codereview.chromium.org/10823350/diff/12/ash/system/tray/system_tray.h...
ash/system/tray/system_tray.h:105: bool IsMouseInNotificationBubble() const;
Should this be for notification bubble only?

http://codereview.chromium.org/10823350/diff/12/ash/system/tray/system_tray_b...
File ash/system/tray/system_tray_bubble.cc (right):

http://codereview.chromium.org/10823350/diff/12/ash/system/tray/system_tray_b...
ash/system/tray/system_tray_bubble.cc:328: tray_->UpdateShouldShowLauncher();
Can this hide the launcher immediately? Or after some delay?

[stevenjb, 2012-08-16 16:59:04]

http://codereview.chromium.org/10823350/diff/12/ash/system/tray/system_tray.h
File ash/system/tray/system_tray.h (right):

http://codereview.chromium.org/10823350/diff/12/ash/system/tray/system_tray.h...
ash/system/tray/system_tray.h:105: bool IsMouseInNotificationBubble() const;
On 2012/08/16 15:31:49, sadrul wrote:
> Should this be for notification bubble only?

It could be either bubble, but we never call this when the default/detailed
bubble is open - the launcher stays visible until that bubble is closed. A minor
optimization, but also I think a little more explicit for what we are checking.
See StatusAreaWidget::UpdateShouldShowLauncher().

http://codereview.chromium.org/10823350/diff/12/ash/system/tray/system_tray_b...
File ash/system/tray/system_tray_bubble.cc (right):

http://codereview.chromium.org/10823350/diff/12/ash/system/tray/system_tray_b...
ash/system/tray/system_tray_bubble.cc:328: tray_->UpdateShouldShowLauncher();
On 2012/08/16 15:31:49, sadrul wrote:
> Can this hide the launcher immediately? Or after some delay?

Currently the launcher is hidden immediately, which is an existing problem that
needs to be fixed in the shelf code. Thanks for the reminder, I went ahead and
filed crbug.com/143178.

[commit-bot: I haz the power, 2012-08-16 22:05:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10823350/6001

[commit-bot: I haz the power, 2012-08-16 22:06:02]

Presubmit check for 10823350-6001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ash

Presubmit checks took 1.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-08-17 00:33:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10823350/6001

[commit-bot: I haz the power, 2012-08-17 02:51:07]

Change committed as 152028