Re-factor system tray code controlling launcher visibility

ash/system/tray/system_tray_bubble.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray_bubble.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/system_tray_item.h"
@@ skipping 302 matching lines @@
   InitializeAndShowBubble(bubble_widget_, bubble_view_, tray_);
 }
 
 void SystemTrayBubble::BubbleViewDestroyed() {
   DestroyItemViews();
   bubble_view_ = NULL;
 }
 
 void SystemTrayBubble::OnMouseEnteredView() {
   StopAutoCloseTimer();
+  tray_->UpdateShouldShowLauncher();
 }
 
 void SystemTrayBubble::OnMouseExitedView() {
   RestartAutoCloseTimer();
+  tray_->UpdateShouldShowLauncher();

[sadrul, 2012/08/16 15:31:49]

Can this hide the launcher immediately? Or after some delay?

[stevenjb, 2012/08/16 16:59:04]

Currently the launcher is hidden immediately, which is an existing problem that
needs to be fixed in the shelf code. Thanks for the reminder, I went ahead and
filed crbug.com/143178.

 }
 
 void SystemTrayBubble::OnClickedOutsideView() {
   if (bubble_type_ != BUBBLE_TYPE_NOTIFICATION)
     bubble_widget_->Close();
 }
 
 void SystemTrayBubble::DestroyItemViews() {
   for (std::vector<ash::SystemTrayItem*>::iterator it = items_.begin();
        it != items_.end();
@@ skipping 73 matching lines @@
 }
 
 void SystemTrayBubble::OnWidgetClosing(views::Widget* widget) {
   CHECK_EQ(bubble_widget_, widget);
   bubble_widget_ = NULL;
   tray_->RemoveBubble(this);
 }
 
 }  // namespace internal
 }  // namespace ash