Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: webkit/fileapi/file_system_url.h

Issue 10823273: Integrate external mount points to IsolatedContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cros test fix Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_url.h
diff --git a/webkit/fileapi/file_system_url.h b/webkit/fileapi/file_system_url.h
index 1d1d57956b957e1f01e369be7f39f3cbb8049c04..c53258fc5e6e16c35ce3db339ceff59815ef679b 100644
--- a/webkit/fileapi/file_system_url.h
+++ b/webkit/fileapi/file_system_url.h
@@ -33,6 +33,10 @@ class FILEAPI_EXPORT FileSystemURL {
// TODO(kinuko): this must be std::string.
const FilePath& path() const { return path_; }
satorux1 2012/08/20 03:51:43 function comment is missing. An example would be h
kinuko 2012/08/20 08:54:35 Done.
+ // Returns the path part of the original filesysstem url.
kmadhusu 2012/08/14 18:01:13 nit: filesystem typo
kinuko 2012/08/20 08:54:35 Done.
+ // Unless the path is cracked further this returns the same path as path().
+ const FilePath& virtual_path() const { return virtual_path_; }
satorux1 2012/08/20 03:51:43 could you describe a bit more about the difference
kinuko 2012/08/20 08:54:35 Done. Also renamed virtual_path() to path_exposed
kinuko 2012/08/20 10:37:54 Per offline chat with tzik@ I renamed this back to
+
// For isolated filesystem.
const std::string& filesystem_id() const { return filesystem_id_; }
@@ -50,7 +54,10 @@ class FILEAPI_EXPORT FileSystemURL {
GURL origin_;
FileSystemType type_;
FilePath path_;
- std::string filesystem_id_; // For isolated filesystem.
+
+ // For isolated filesystem.
+ std::string filesystem_id_;
+ FilePath virtual_path_;
bool is_valid_;
};

Powered by Google App Engine
This is Rietveld 408576698