Integrate external mount points to IsolatedContext

webkit/fileapi/file_system_url.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_URL_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_URL_H_
 
 #include <string>
 
 #include "base/file_path.h"
@@ skipping 13 matching lines @@
   FileSystemURL(const GURL& origin,
                 FileSystemType type,
                 const FilePath& internal_path);
   ~FileSystemURL();
 
   bool is_valid() const { return is_valid_; }
   const GURL& origin() const { return origin_; }
   FileSystemType type() const { return type_; }
 
   // TODO(kinuko): this must be std::string.
   const FilePath& path() const { return path_; }

[satorux1, 2012/08/20 03:51:43]

function comment is missing. An example would be helpful.

[kinuko, 2012/08/20 08:54:35]

Done.

 
+  // Returns the path part of the original filesysstem url.

[kmadhusu, 2012/08/14 18:01:13]

nit: filesystem typo

[kinuko, 2012/08/20 08:54:35]

Done.

+  // Unless the path is cracked further this returns the same path as path().
+  const FilePath& virtual_path() const { return virtual_path_; }

[satorux1, 2012/08/20 03:51:43]

could you describe a bit more about the difference between path()? Examples
would be helpful to understand.

[kinuko, 2012/08/20 08:54:35]

Done.  Also renamed virtual_path() to path_exposed_in_url() to try to make it
look clearer.

[kinuko, 2012/08/20 10:37:54]

Per offline chat with tzik@ I renamed this back to virtual_path() as it might be
more intuitive.

+
   // For isolated filesystem.
   const std::string& filesystem_id() const { return filesystem_id_; }
 
   std::string spec() const;
 
   // Returns a new FileSystemURL with the given path.
   // This doesn't change the calling instance's data.
   FileSystemURL WithPath(const FilePath& path) const;
 
   bool operator==(const FileSystemURL& that) const;
 
  private:
   void MayCrackIsolatedPath();
 
   GURL origin_;
   FileSystemType type_;
   FilePath path_;
-  std::string filesystem_id_;  // For isolated filesystem.
+
+  // For isolated filesystem.
+  std::string filesystem_id_;
+  FilePath virtual_path_;
 
   bool is_valid_;
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_URL_H_