Issue 10823271: Add ability to write include rules specific to subsets of files in a directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823271: Add ability to write include rules specific to subsets of files in a directory. (Closed)

Created:
8 years, 4 months ago by Jói

Modified:
8 years, 4 months ago

Reviewers:
erikwright (departed)

CC:
chromium-reviews, pam+watch_chromium.org, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add ability to write include rules specific to subsets of files in a directory. This is useful e.g. to limit a set of allowed or temporarily-allowed include rules to test files, or to allow certain includes in .cc files but not in .h files. BUG=138280 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151301

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Merge to head. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -38 lines)			Patch
M	tools/checkdeps/checkdeps.py	View	1	6 chunks	+44 lines, -8 lines	0 comments	Download
M	tools/checkdeps/checkdeps_test.py	View		4 chunks	+6 lines, -3 lines	0 comments	Download
M	tools/checkdeps/cpp_checker.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/checkdeps/java_checker.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/checkdeps/results.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/checkdeps/rules.py	View	1	4 chunks	+76 lines, -20 lines	0 comments	Download
M	tools/checkdeps/testdata/allowed/DEPS	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A +	tools/checkdeps/testdata/allowed/foo_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/checkdeps/testdata/allowed/not_a_test.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jói

Hi Erik, I'm planning to use this in autofill to isolate those dependencies from chrome/browser ...

8 years, 4 months ago (2012-08-10 14:47:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10823271/2003

8 years, 4 months ago (2012-08-13 16:23:25 UTC) #3

Change committed as 151301

Expand Messages | Collapse Messages