tools/checkdeps/java_checker.py - Issue 10823271: Add ability to write include rules specific to subsets of files in a directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/checkdeps/java_checker.py

Issue 10823271: Add ability to write include rules specific to subsets of files in a directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge to head. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/checkdeps/java_checker.py

diff --git a/tools/checkdeps/java_checker.py b/tools/checkdeps/java_checker.py

index d6633b8351b95d5edb02eb7a3b222aee2b547ae5..670eac216457fc44f5c01808cd443b2b761b1fee 100644

--- a/tools/checkdeps/java_checker.py

+++ b/tools/checkdeps/java_checker.py

@@ -96,7 +96,7 @@ class JavaChecker(object):

self._classmap[clazz], self._base_directory)

# Convert Windows paths to Unix style, as used in DEPS files.

include_path = include_path.replace(os.path.sep, '/')

- rule = rules.RuleApplyingTo(include_path)

+ rule = rules.RuleApplyingTo(include_path, filepath)

if rule.allow == Rule.DISALLOW:

dependee_status.AddViolation(

results.DependencyViolation(include_path, rule, rules))

« no previous file with comments | « tools/checkdeps/cpp_checker.py ('k') | tools/checkdeps/results.py » ('j') | no next file with comments »