Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: chrome/browser/ui/views/external_tab_container_win.cc

Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Return NULL as the ToggleDevToolsWindow() result for DevTools windows Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/external_tab_container_win.cc
diff --git a/chrome/browser/ui/views/external_tab_container_win.cc b/chrome/browser/ui/views/external_tab_container_win.cc
index 841baaafc0b6745e85b676f95c9ae5b648b2d993..51651595a0f90c4d9ccc967e8bc494b444cd260e 100644
--- a/chrome/browser/ui/views/external_tab_container_win.cc
+++ b/chrome/browser/ui/views/external_tab_container_win.cc
@@ -1061,7 +1061,7 @@ bool ExternalTabContainerWin::AcceleratorPressed(
case IDC_DEV_TOOLS:
DevToolsWindow::ToggleDevToolsWindow(
tab_contents_->web_contents()->GetRenderViewHost(),
- DEVTOOLS_TOGGLE_ACTION_NONE);
+ DEVTOOLS_TOGGLE_ACTION_SHOW);
break;
case IDC_DEV_TOOLS_CONSOLE:
DevToolsWindow::ToggleDevToolsWindow(
@@ -1073,6 +1073,11 @@ bool ExternalTabContainerWin::AcceleratorPressed(
tab_contents_->web_contents()->GetRenderViewHost(),
DEVTOOLS_TOGGLE_ACTION_INSPECT);
break;
+ case IDC_DEV_TOOLS_TOGGLE:
+ DevToolsWindow::ToggleDevToolsWindow(
+ tab_contents_->web_contents()->GetRenderViewHost(),
+ DEVTOOLS_TOGGLE_ACTION_TOGGLE);
+ break;
default:
NOTREACHED() << "Unsupported accelerator: " << command_id;
return false;
« chrome/browser/debugger/devtools_window.cc ('K') | « chrome/browser/ui/views/accelerator_table.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698