chrome/browser/ui/views/accelerator_table.cc - Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/accelerator_table.cc

Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Return NULL as the ToggleDevToolsWindow() result for DevTools windows Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/debugger/devtools_window.cc ('K') | « chrome/browser/ui/gtk/accelerators_gtk.cc ('k') | chrome/browser/ui/views/external_tab_container_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/accelerator_table.cc

diff --git a/chrome/browser/ui/views/accelerator_table.cc b/chrome/browser/ui/views/accelerator_table.cc

index 1476d4bfe8493f6274a73a0dbc9afd40913802b2..3c5b05679ecad055b9d8ccc36f11a8859012c8ed 100644

--- a/chrome/browser/ui/views/accelerator_table.cc

+++ b/chrome/browser/ui/views/accelerator_table.cc

@@ -34,7 +34,7 @@ const AcceleratorMapping kAcceleratorMap[] = {

{ ui::VKEY_RIGHT, ui::EF_ALT_DOWN, IDC_FORWARD },

{ ui::VKEY_BACK, ui::EF_SHIFT_DOWN, IDC_FORWARD },

{ ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_DEV_TOOLS },

- { ui::VKEY_F12, ui::EF_NONE, IDC_DEV_TOOLS },

+ { ui::VKEY_F12, ui::EF_NONE, IDC_DEV_TOOLS_TOGGLE },

{ ui::VKEY_J, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,

IDC_DEV_TOOLS_CONSOLE },

{ ui::VKEY_C, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,