Chromium Code Reviews Chromium Code Reviews
Issue 10823214:
Add a chrome://nacl page to show if NaCl is enabled and if PNaCl is installed. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/resources/about_nacl.html |
| diff --git a/chrome/browser/resources/about_nacl.html b/chrome/browser/resources/about_nacl.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..cd6cff146ad5ed162e82e0e56d6af5f17a27c3cb |
| --- /dev/null |
| +++ b/chrome/browser/resources/about_nacl.html |
| @@ -0,0 +1,34 @@ |
| +<!DOCTYPE HTML> |
| +<html i18n-values="dir:textdirection;"> |
| +<head> |
| +<style> |
|
James Hawkins
2012/08/09 17:16:55
No styles in the html.
jvoung (off chromium)
2012/08/09 20:03:35
Sorry, was just following the pattern of other abo
|
| +.key { |
| + font-weight: bold; |
| +} |
| + |
| +.value { |
| + margin-left: 15px; |
| +} |
| +</style> |
| +</head> |
| +<body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> |
| +<div id="loading-message" i18n-content="loadingMessage">LOADING_MESSAGE</div> |
|
James Hawkins
2012/08/09 17:16:55
s/LOADING_MESSAGE//
Remove all inline text conten
jvoung (off chromium)
2012/08/09 20:03:35
Done.
|
| +<div id="body-container" style="visibility:hidden"> |
|
James Hawkins
2012/08/09 17:16:55
Use the hidden attribute instead.
jvoung (off chromium)
2012/08/09 20:03:35
Done.
|
| + <div id="header"><h1 i18n-content="naclLongTitle">ABOUT_NACL</h1></div> |
|
James Hawkins
2012/08/09 17:16:55
nit: <h1> must be dropped down and indented.
jvoung (off chromium)
2012/08/09 20:03:35
Done.
|
| + |
|
James Hawkins
2012/08/09 17:16:55
nit: Remove blank line.
jvoung (off chromium)
2012/08/09 20:03:35
Done.
|
| + <div id="naclInfoTemplate"> |
| + <table cellpadding="2" cellspacing="0" border="0"> |
|
James Hawkins
2012/08/09 17:16:55
Don't use table for non-tabular data.
jvoung (off chromium)
2012/08/09 20:03:35
Done.
|
| + <tr jsselect="naclInfo"> |
| + <td><span dir="ltr" jscontent="key" class="key">KEY</span></td> |
| + <td><span dir="ltr" jscontent="value" class="value">VALUE</span></td> |
| + </tr> |
| + </table> |
| + </div> |
| +</div> |
| +<script src="chrome://nacl/about_nacl.js"></script> |
| +<script src="chrome://nacl/strings.js"></script> |
| +<script src="chrome://resources/js/i18n_template.js"></script> |
| +<script src="chrome://resources/js/i18n_process.js"></script> |
| +<script src="chrome://resources/js/jstemplate_compiled.js"></script> |
| +</body> |
| +</html> |
