chrome/browser/resources/about_nacl.html - Issue 10823214: Add a chrome://nacl page to show if NaCl is enabled and if PNaCl is installed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/about_nacl.html

Issue 10823214: Add a chrome://nacl page to show if NaCl is enabled and if PNaCl is installed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: handle disable_nacl=1 Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html i18n-values="dir:textdirection;">

	3 <head>

	4 <style>
	James Hawkins 2012/08/09 17:16:55 No styles in the html. No styles in the html. jvoung (off chromium) 2012/08/09 20:03:35 Sorry, was just following the pattern of other abo Show quoted text On 2012/08/09 17:16:55, James Hawkins wrote: > No styles in the html. Sorry, was just following the pattern of other about_*.html. Moved to a .css file.
	5 .key {

	6 font-weight: bold;

	7 }

	8

	9 .value {

	10 margin-left: 15px;

	11 }

	12 </style>

	13 </head>

	14 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">

	15 <div id="loading-message" i18n-content="loadingMessage">LOADING_MESSAGE</div>
	James Hawkins 2012/08/09 17:16:55 s/LOADING_MESSAGE// Remove all inline text conten s/LOADING_MESSAGE// Remove all inline text content. jvoung (off chromium) 2012/08/09 20:03:35 Done. Show quoted text On 2012/08/09 17:16:55, James Hawkins wrote: > s/LOADING_MESSAGE// > > Remove all inline text content. Done.
	16 <div id="body-container" style="visibility:hidden">
	James Hawkins 2012/08/09 17:16:55 Use the hidden attribute instead. Use the hidden attribute instead. jvoung (off chromium) 2012/08/09 20:03:35 Done. Show quoted text On 2012/08/09 17:16:55, James Hawkins wrote: > Use the hidden attribute instead. Done.
	17 <div id="header"><h1 i18n-content="naclLongTitle">ABOUT_NACL</h1></div>
	James Hawkins 2012/08/09 17:16:55 nit: <h1> must be dropped down and indented. nit: <h1> must be dropped down and indented. jvoung (off chromium) 2012/08/09 20:03:35 Done. Show quoted text On 2012/08/09 17:16:55, James Hawkins wrote: > nit: <h1> must be dropped down and indented. Done.
	18
	James Hawkins 2012/08/09 17:16:55 nit: Remove blank line. nit: Remove blank line. jvoung (off chromium) 2012/08/09 20:03:35 Done. Show quoted text On 2012/08/09 17:16:55, James Hawkins wrote: > nit: Remove blank line. Done.
	19 <div id="naclInfoTemplate">

	20 <table cellpadding="2" cellspacing="0" border="0">
	James Hawkins 2012/08/09 17:16:55 Don't use table for non-tabular data. Don't use table for non-tabular data. jvoung (off chromium) 2012/08/09 20:03:35 Done. Show quoted text On 2012/08/09 17:16:55, James Hawkins wrote: > Don't use table for non-tabular data. Done.
	21 <tr jsselect="naclInfo">

	22 <td><span dir="ltr" jscontent="key" class="key">KEY</span></td>

	23 <td><span dir="ltr" jscontent="value" class="value">VALUE</span></td>

	24 </tr>

	25 </table>

	26 </div>

	27 </div>

	28 <script src="chrome://nacl/about_nacl.js"></script>

	29 <script src="chrome://nacl/strings.js"></script>

	30 <script src="chrome://resources/js/i18n_template.js"></script>

	31 <script src="chrome://resources/js/i18n_process.js"></script>

	32 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

	33 </body>

	34 </html>

OLD	NEW

« chrome/app/generated_resources.grd ('K') | « chrome/browser/browser_resources.grd ('k') | chrome/browser/resources/about_nacl.js » ('j') | chrome/browser/resources/about_nacl.js » ('J')