Add a flag to specify the amount of total GPU memory available.

Add a flag to specify the total amount of memory which may be allocated to GPU resources.

Change constants in GpuMemoryManager to helper functions (and variables).

This is towards (1) automated testing of the GPU memory manager and (2) getting actual vidmem values.

BUG=132994
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149149

[greggman, 2012-07-31 00:30:41]

just some style issues otherwise LGTM

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_manager.cc (right):

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.cc:55: const int viewportMultiplier = 16;
style: constants are kCamelCase

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.cc:88: else {
style: open an close braces go on same line for 'else'

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.cc:262:
stubs_with_surface_foreground.size();
style: indent? i'm not 100% sure this is wrong. It seems like would be lined up
with = or 4 in from the start of bonus_allocation

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_manager_unittest.cc (right):

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager_unittest.cc:122:
GetMinimumTabAllocation();
style: I don't think these are supposed to be indented.

[ccameron, 2012-07-31 00:52:49]

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_manager.cc (right):

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.cc:55: const int viewportMultiplier = 16;
On 2012/07/31 00:30:41, greggman wrote:
> style: constants are kCamelCase

Done.  This was a copy-paste of the function (moving it out of the
namespace-block).

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.cc:88: else {
On 2012/07/31 00:30:41, greggman wrote:
> style: open an close braces go on same line for 'else'

Done.  There was another instance of this later in the file, fixed too.

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.cc:262:
stubs_with_surface_foreground.size();
On 2012/07/31 00:30:41, greggman wrote:
> style: indent? i'm not 100% sure this is wrong. It seems like would be lined
up
> with = or 4 in from the start of bonus_allocation

Done.  Lined up with the =, since that seems most reasonable.

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_manager_unittest.cc (right):

http://codereview.chromium.org/10823092/diff/2001/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager_unittest.cc:122:
GetMinimumTabAllocation();
On 2012/07/31 00:30:41, greggman wrote:
> style: I don't think these are supposed to be indented.

I'm not sure on this -- it'a a compound clause with the >= and the ==. 
Fortunately we can avoid the question by bumping off the newline.

[commit-bot: I haz the power, 2012-07-31 01:05:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/10823092/5001

[ccameron, 2012-07-31 01:33:21]

On 2012/07/31 01:05:57, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/ccameron%40chromium.org/10823092/5001

I removed some #if ANDROID lines around a helper function because this function
caused failures that I only discovered via a commit-bot.  LMK if you want to
re-review this.

[commit-bot: I haz the power, 2012-07-31 06:50:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/10823092/10001

[commit-bot: I haz the power, 2012-07-31 08:46:49]

Change committed as 149149