content/renderer/render_view_impl.cc - Issue 10823077: Throttle SelectRange IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 10823077: Throttle SelectRange IPC (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index d88f508af7ad284405a01581d59a1b899b3615c3..0f46517fed18bf6c147a5bd9ebbe82372790c65a 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1272,6 +1272,7 @@ void RenderViewImpl::OnSelectRange(const gfx::Point& start,

handling_select_range_ = true;

webview()->focusedFrame()->selectRange(start, end);

handling_select_range_ = false;

+ Send(new ViewHostMsg_SelectRange_ACK(routing_id_));

darin (slow to review) 2012/08/02 06:30:20 nit: I suggest sending the ACK before calling sele

Iain Merrick 2012/08/02 10:25:42 Done.

}

void RenderViewImpl::OnSetHistoryLengthAndPrune(int history_length,