Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 10823077: Throttle SelectRange IPC (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.h
diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h
index b6544af532fe3fb8696ddbd9193bf3fbcacc8683..c0e89d09f7c5a13f4a6f12409129f6d04c11bd9e 100644
--- a/content/browser/renderer_host/render_widget_host_impl.h
+++ b/content/browser/renderer_host/render_widget_host_impl.h
@@ -552,6 +552,8 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public RenderWidgetHost,
void OnMsgDestroyPluginContainer(gfx::PluginWindowHandle id);
#endif
+ void OnMsgSelectRangeAck();
darin (slow to review) 2012/08/02 06:30:20 nit: it seems like this should be listed after OnM
Iain Merrick 2012/08/02 10:25:42 Done.
+
// Called (either immediately or asynchronously) after we're done with our
// BackingStore and can send an ACK to the renderer so it can paint onto it
// again.
@@ -687,6 +689,12 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public RenderWidgetHost,
// are coalesced by merging deltas in a similar fashion as wheel events.
GestureEventQueue coalesced_gesture_events_;
+ // Throttling text selection IPC, allowing at most one unACKed IPC in flight.
+ gfx::Point pend_select_start_;
darin (slow to review) 2012/08/02 06:30:20 nit: please use words. pend -> pending?
Iain Merrick 2012/08/02 10:25:42 Done. In fact I'll rename things a bit because usi
+ gfx::Point pend_select_end_;
+ bool select_range_in_flight_;
+ bool select_range_pending_;
+
// The time when an input event was sent to the RenderWidget.
base::TimeTicks input_event_start_time_;
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | content/renderer/render_view_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698