Throttle SelectRange IPC

content/browser/renderer_host/render_widget_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
 
 #include <deque>
 #include <string>
 #include <vector>
@@ skipping 534 matching lines @@
                                            int32 height,
                                            TransportDIB::Handle transport_dib);
   void OnAcceleratedSurfaceBuffersSwapped(gfx::PluginWindowHandle window,
                                           uint64 surface_handle);
 #endif
 #if defined(TOOLKIT_GTK)
   void OnMsgCreatePluginContainer(gfx::PluginWindowHandle id);
   void OnMsgDestroyPluginContainer(gfx::PluginWindowHandle id);
 #endif
 
+  void OnMsgSelectRangeAck();

[darin (slow to review), 2012/08/02 06:30:20]

nit: it seems like this should be listed after OnMsgBeginSmoothScroll since you
place it after that function in the .cc file.

[Iain Merrick, 2012/08/02 10:25:42]

Done.

+
   // Called (either immediately or asynchronously) after we're done with our
   // BackingStore and can send an ACK to the renderer so it can paint onto it
   // again.
   void DidUpdateBackingStore(const ViewHostMsg_UpdateRect_Params& params,
                              const base::TimeTicks& paint_start);
 
   // Paints the given bitmap to the current backing store at the given
   // location.  Returns true if the passed callback was asynchronously
   // scheduled in the future (and thus the caller must manually synchronously
   // call the callback function).
@@ skipping 115 matching lines @@
   // (Similar to |mouse_wheel_pending_|.). True if gesture event was sent and
   // we are waiting for a corresponding ack.
   bool gesture_event_pending_;
 
   typedef std::deque<WebKit::WebGestureEvent> GestureEventQueue;
 
   // (Similar to |coalesced_mouse_wheel_events_|.) GestureScrollUpdate events
   // are coalesced by merging deltas in a similar fashion as wheel events.
   GestureEventQueue coalesced_gesture_events_;
 
+  // Throttling text selection IPC, allowing at most one unACKed IPC in flight.
+  gfx::Point pend_select_start_;

[darin (slow to review), 2012/08/02 06:30:20]

nit: please use words.  pend -> pending?

[Iain Merrick, 2012/08/02 10:25:42]

Done. In fact I'll rename things a bit because using 'pending' in two different
senses seems very confusing.

+  gfx::Point pend_select_end_;
+  bool select_range_in_flight_;
+  bool select_range_pending_;
+
   // The time when an input event was sent to the RenderWidget.
   base::TimeTicks input_event_start_time_;
 
   // Keyboard event listeners.
   std::list<KeyboardListener*> keyboard_listeners_;
 
   // If true, then we should repaint when restoring even if we have a
   // backingstore.  This flag is set to true if we receive a paint message
   // while is_hidden_ to true.  Even though we tell the render widget to hide
   // itself, a paint message could already be in flight at that point.
@@ skipping 79 matching lines @@
   scoped_ptr<TapSuppressionController> tap_suppression_controller_;
 
   scoped_ptr<SmoothScrollGesture> active_smooth_scroll_gesture_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_