media/mp4/offset_byte_queue_unittest.cc - Issue 10823069: Make peeking before the head of OffsetByteQueue a hard error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/offset_byte_queue_unittest.cc

Issue 10823069: Make peeking before the head of OffsetByteQueue a hard error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove death test Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mp4/offset_byte_queue_unittest.cc

diff --git a/media/mp4/offset_byte_queue_unittest.cc b/media/mp4/offset_byte_queue_unittest.cc

index 3a9b133b281a860ac69e1b1a4d4a69591a36057d..e2d40dc67c7ed77615ea6cdc44f184c08150f885 100644

--- a/media/mp4/offset_byte_queue_unittest.cc

+++ b/media/mp4/offset_byte_queue_unittest.cc

@@ -48,10 +48,6 @@ TEST_F(OffsetByteQueueTest, TestPeekAt) {

const uint8* buf;

int size;

- queue_->PeekAt(128, &buf, &size);

- EXPECT_EQ(NULL, buf);

- EXPECT_EQ(0, size);

queue_->PeekAt(400, &buf, &size);

EXPECT_EQ(queue_->tail() - 400, size);

EXPECT_EQ(400 - 256, buf[0]);

« no previous file with comments | « media/mp4/offset_byte_queue.cc ('k') | no next file » | no next file with comments »