media/mp4/offset_byte_queue.cc - Issue 10823069: Make peeking before the head of OffsetByteQueue a hard error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/offset_byte_queue.cc

Issue 10823069: Make peeking before the head of OffsetByteQueue a hard error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove death test Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mp4/offset_byte_queue.cc

diff --git a/media/mp4/offset_byte_queue.cc b/media/mp4/offset_byte_queue.cc

index 862d9370b20b58ffdee8f874c5a4ba2b6c574e44..a530150899bce18a9ec56c9c8d03aa361943864e 100644

--- a/media/mp4/offset_byte_queue.cc

+++ b/media/mp4/offset_byte_queue.cc

@@ -37,6 +37,7 @@ void OffsetByteQueue::Pop(int count) {

}

void OffsetByteQueue::PeekAt(int64 offset, const uint8** buf, int* size) {

+ DCHECK(offset >= head());

if (offset < head() || offset >= tail()) {

*buf = NULL;

*size = 0;

« no previous file with comments | « no previous file | media/mp4/offset_byte_queue_unittest.cc » ('j') | no next file with comments »