Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java

Issue 10823051: ContentShell rendering support on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address Ted's comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java
diff --git a/content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java b/content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java
index c4ca176fe85a413467072ea203936a6d6e370549..039bef5808cb9f54f94bd30a7bd2dddbca0fbc0a 100644
--- a/content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java
+++ b/content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java
@@ -25,7 +25,7 @@ public class ContentShellActivity extends Activity {
private static final String TAG = ContentShellActivity.class.getName();
private static final String ACTIVE_SHELL_URL_KEY = "activeUrl";
- private static final String DEFAULT_SHELL_URL = "http://www.google.com";
+ public static final String DEFAULT_SHELL_URL = "http://www.google.com";
private ShellManager mShellManager;
@@ -35,11 +35,6 @@ public class ContentShellActivity extends Activity {
// Initializing the command line must occur before loading the library.
if (!CommandLine.isInitialized()) CommandLine.initFromFile(COMMAND_LINE_FILE);
- String startupUrl = getUrlFromIntent(getIntent());
- if (!TextUtils.isEmpty(startupUrl)) {
- CommandLine.getInstance().appendSwitchesAndArguments(
- new String[] {Shell.sanitizeUrl(startupUrl)});
- }
waitForDebuggerIfNeeded();
LibraryLoader.loadAndInitSync();
@@ -47,6 +42,12 @@ public class ContentShellActivity extends Activity {
setContentView(R.layout.content_shell_activity);
mShellManager = (ShellManager) findViewById(R.id.shell_container);
+
+ String startupUrl = getUrlFromIntent(getIntent());
+ if (!TextUtils.isEmpty(startupUrl)) {
+ mShellManager.setStartupUrl(Shell.sanitizeUrl(startupUrl));
+ }
+
if (!ContentView.enableMultiProcess(this, ContentView.MAX_RENDERERS_AUTOMATIC)) {
String shellUrl = DEFAULT_SHELL_URL;
if (savedInstanceState != null

Powered by Google App Engine
This is Rietveld 408576698