Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 10823040: Remove unused files after SignedSettings is dead. (Closed)

Created:
8 years, 5 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Chris Masone
Visibility:
Public.

Description

Remove unused files after SignedSettings is dead. Remove files belonging to the SignedSettings interface to Chrome OS device settings, which has been abandoned in favor of DeviceSettingsService. BUG=chromium:139126 TEST=Still compiles, no functional changes. TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155725

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3344 lines) Patch
D chrome/browser/chromeos/settings/mock_owner_key_utils.h View 1 2 3 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/chromeos/settings/mock_owner_key_utils.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/chromeos/settings/mock_ownership_service.h View 1 2 3 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/chromeos/settings/mock_ownership_service.cc View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/chromeos/settings/mock_signed_settings_helper.h View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/chromeos/settings/mock_signed_settings_helper.cc View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/chromeos/settings/owner_key_utils.h View 1 2 3 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/chromeos/settings/owner_key_utils.cc View 1 2 3 1 chunk +0 lines, -175 lines 0 comments Download
D chrome/browser/chromeos/settings/owner_key_utils_unittest.cc View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/chromeos/settings/owner_manager.h View 1 2 3 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/chromeos/settings/owner_manager.cc View 1 2 3 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/chromeos/settings/owner_manager_unittest.h View 1 2 3 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/chromeos/settings/owner_manager_unittest.cc View 1 2 3 1 chunk +0 lines, -347 lines 0 comments Download
D chrome/browser/chromeos/settings/ownership_service.h View 1 2 3 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/chromeos/settings/ownership_service.cc View 1 2 3 1 chunk +0 lines, -259 lines 0 comments Download
D chrome/browser/chromeos/settings/ownership_service_unittest.cc View 1 2 3 1 chunk +0 lines, -238 lines 0 comments Download
D chrome/browser/chromeos/settings/session_manager_observer.h View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/chromeos/settings/session_manager_observer.cc View 1 2 3 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/chromeos/settings/signed_settings.h View 1 2 3 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/chromeos/settings/signed_settings.cc View 1 2 3 1 chunk +0 lines, -290 lines 0 comments Download
D chrome/browser/chromeos/settings/signed_settings_helper.h View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/chromeos/settings/signed_settings_helper.cc View 1 2 3 1 chunk +0 lines, -251 lines 0 comments Download
D chrome/browser/chromeos/settings/signed_settings_helper_unittest.cc View 1 2 3 1 chunk +0 lines, -212 lines 0 comments Download
D chrome/browser/chromeos/settings/signed_settings_unittest.cc View 1 2 3 1 chunk +0 lines, -400 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mattias Nissler (ping if slow)
Number three: He's dead, Jim!
8 years, 5 months ago (2012-07-26 15:23:39 UTC) #1
pastarmovj
lgtm
8 years, 4 months ago (2012-07-30 13:56:03 UTC) #2
Nikita (slow)
lgtm
8 years, 4 months ago (2012-07-31 04:55:35 UTC) #3
Mattias Nissler (ping if slow)
+Ben to TBR for gyp changes and the removed notifications.
8 years, 3 months ago (2012-09-10 12:28:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/10823040/20001
8 years, 3 months ago (2012-09-10 12:28:35 UTC) #5
commit-bot: I haz the power
Presubmit check for 10823040-20001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-10 12:28:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/10823040/20001
8 years, 3 months ago (2012-09-10 12:31:46 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 14:44:53 UTC) #8
Change committed as 155725

Powered by Google App Engine
This is Rietveld 408576698