Issue 10822022: Added extra DCHECK() to eliminate possible NULL deref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10822022: Added extra DCHECK() to eliminate possible NULL deref. (Closed)

Created:
8 years, 5 months ago by Kyle Horimoto

Modified:
8 years, 5 months ago

Reviewers:
James Hawkins, Ben Goodger (Google), Tyler Breisacher (Chromium)

CC:
chromium-reviews, tfarina, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added extra DCHECK() to eliminate possible NULL deref. CID=104002 BUG= TEST= TBR=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148434

Patch Set 1 #

Patch Set 2 : Remove .gitmodule #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10822022/2001

8 years, 5 months ago (2012-07-25 20:51:53 UTC) #3

James Hawkins

8 years, 5 months ago (2012-07-26 00:10:50 UTC) #5

http://codereview.chromium.org/10822022/diff/2001/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab_drag_controller.cc (right):

http://codereview.chromium.org/10822022/diff/2001/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_drag_controller.cc:1613: DCHECK(started_drag_
&& source_tabstrip_);
nit: Don't put two conditions in one DCHECK, otherwise it's harder to see which
value is causing the failure.

Expand Messages | Collapse Messages