chrome/browser/ui/views/tabs/tab_drag_controller.cc - Issue 10822022: Added extra DCHECK() to eliminate possible NULL deref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 10822022: Added extra DCHECK() to eliminate possible NULL deref. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove .gitmodule Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

index c0757320ac40b5752178fa615f0ca13f9feac230..c9c6f26f031161b4bbfb40e9f02ae40368d56fda 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

@@ -1610,7 +1610,7 @@ void TabDragController::ResetSelection(TabStripModel* model) {

}

void TabDragController::RevertDragAt(size_t drag_index) {

- DCHECK(started_drag_);

+ DCHECK(started_drag_ && source_tabstrip_);

James Hawkins 2012/07/26 00:10:50 nit: Don't put two conditions in one DCHECK, other

TabDragData* data = &(drag_data_[drag_index]);

if (attached_tabstrip_) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »