chrome/browser/extensions/api/omnibox/omnibox_apitest.cc - Issue 10810062: Moving common code into OmniboxView from OmniboxView*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

Issue 10810062: Moving common code into OmniboxView from OmniboxView* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: public destructor Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc b/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

index 4b4e1db93c8fe5fe07422978f0bcc75e4850484a..3deed79205082e8a3ff609ae569745bc504219a4 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

@@ -52,8 +52,8 @@ class OmniboxApiTest : public ExtensionApiTest {

}

AutocompleteController* GetAutocompleteController(Browser* browser) const {

- return GetLocationBar(browser)->GetLocationEntry()->model()->popup_model()->

- autocomplete_controller();

+ return GetLocationBar(browser)->GetLocationEntry()->model()->

+ popup_model()->autocomplete_controller();

Peter Kasting 2012/07/26 23:03:24 Nit: This change doesn't really improve things, I'

dominich 2012/07/27 20:33:54 hangover from model->GetModel->model rename.

}

// TODO(phajdan.jr): Get rid of this wait-in-a-loop pattern.