Moving common code into OmniboxView from OmniboxView*

chrome/browser/extensions/api/omnibox/omnibox_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/format_macros.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_input.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
@@ skipping 34 matching lines @@
 
 }  // namespace
 
 class OmniboxApiTest : public ExtensionApiTest {
  protected:
   LocationBar* GetLocationBar(Browser* browser) const {
     return browser->window()->GetLocationBar();
   }
 
   AutocompleteController* GetAutocompleteController(Browser* browser) const {
-    return GetLocationBar(browser)->GetLocationEntry()->model()->popup_model()->
-        autocomplete_controller();
+    return GetLocationBar(browser)->GetLocationEntry()->model()->
+        popup_model()->autocomplete_controller();

[Peter Kasting, 2012/07/26 23:03:24]

Nit: This change doesn't really improve things, I'd just revert

[dominich, 2012/07/27 20:33:54]

hangover from model->GetModel->model rename.

   }
 
   // TODO(phajdan.jr): Get rid of this wait-in-a-loop pattern.
   void WaitForAutocompleteDone(AutocompleteController* controller) {
     while (!controller->done()) {
       content::WindowedNotificationObserver ready_observer(
           chrome::NOTIFICATION_AUTOCOMPLETE_CONTROLLER_RESULT_READY,
           content::Source<AutocompleteController>(controller));
       ready_observer.Wait();
     }
@@ skipping 205 matching lines @@
   // incognito context.
   {
     ResultCatcher catcher;
     autocomplete_controller->Start(
         ASCIIToUTF16("keyword command incognito"), string16(),
         true, false, true, AutocompleteInput::ALL_MATCHES);
     location_bar->AcceptInput();
     EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
   }
 }