Chromium Code Reviews Chromium Code Reviews
Issue
10810021:
Register Chrome in Active Setup to be called by Windows at user login. (Closed)
DescriptionRegister Chrome in Active Setup to be called by Windows at user login.
This commit also adds --configure-user-settings flag to setup.exe which Active Setup will invoke at user login on system-level installs. For now this flag doesn't do anything (it will be implemented in a follow up CL).
Active Setup design doc: https://docs.google.com/a/chromium.org/document/d/1yQdG1wMDKi_lf0i8bk6P2_BWqudRb-ap6Y2C5f1RO2w/edit
This CL also introduces ScopedTokenPrivilege, a class meant to give the current process's token privileges for a short period of time while some critical operations (loading other users' registry hives) are happening.
BUG=132825
TEST=From an admin prompt: setup_unittests.exe --gtest_filter=SetupUtilTest.ScopedTokenPrivilege*
Windows only calls Active Setup's StubPath (i.e. setup.exe --configure-user-settings) if:
1) It never called it before (i.e. the HKCU equivalence of the Chrome Active Setup doesn't exist for this user).
or
2) The version in HKLM is greater than the version in HKCU (i.e. Chrome has been updated since the last user login).
Uninstalling Chrome deletes the HKCU entries for all users (logged in or not).
Later reinstalling an older version of Chrome (just reinstall and manually hack the HKLM Active Setup version) has every user go through Active Setup again (if we didn't delete the values ourselves it wouldn't... which is why I had to introduce 75% of this CL simply to delete the HKCU Active Setup entries created by Windows for every user...)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147667
Patch Set 1 : #
Total comments: 18
Patch Set 2 : address tommi's comments #Patch Set 3 : rebase onto 147656 #
Messages
Total messages: 9 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
