Issue 10809069: dart2dart compiler support.

Issue 10809069: dart2dart compiler support. (Closed)

Created:
8 years, 5 months ago by Anton Muhin

Modified:
8 years, 5 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, Roman

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2dart compiler support. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=9880

Patch Set 2 : Next iteration #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+850 lines, -36 lines)			Patch
M	runtime/tests/vm/vm.status	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	samples/tests/samples/samples.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1	1 chunk	+82 lines, -0 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+532 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+86 lines, -0 lines	0 comments	Download
M	tests/utils/utils.status	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1	7 chunks	+30 lines, -26 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	11 chunks	+44 lines, -7 lines	0 comments	Download
M	utils/tests/pub/pub.status	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

If overall approach is ok, I'll adjust .status files as well.

8 years, 5 months ago (2012-07-24 11:11:14 UTC) #2

Bill Hesse

LGTM. http://codereview.chromium.org/10809069/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): http://codereview.chromium.org/10809069/diff/1/tools/testing/dart/test_options.dart#newcode409 tools/testing/dart/test_options.dart:409: case 'dart2dart': See below. const ['vm', 'drt', 'dartium'].some(equals(config['runtime'])) ...

8 years, 5 months ago (2012-07-24 11:58:59 UTC) #3

Anton Muhin

8 years, 5 months ago (2012-07-25 11:19:56 UTC) #4

Thanks a lot for review, Bill, submitting

http://codereview.chromium.org/10809069/diff/1/tools/testing/dart/test_option...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/10809069/diff/1/tools/testing/dart/test_option...
tools/testing/dart/test_options.dart:409: case 'dart2dart':
On 2012/07/24 11:58:59, Bill Hesse wrote:
> See below.
> const ['vm', 'drt', 'dartium'].some(equals(config['runtime']))

Done.

http://codereview.chromium.org/10809069/diff/1/tools/testing/dart/test_suite....
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/10809069/diff/1/tools/testing/dart/test_suite....
tools/testing/dart/test_suite.dart:707: args.add('--output-type=dart
--out=$outputFile');
On 2012/07/24 11:58:59, Bill Hesse wrote:
> This should be args.addAll(['--output-type=dart', '--out=$outputFile']), but
> even better is
>     case 'dart2js':
>     case 'dart2dart':
>       if (compiler == 'dart2dart') args.add('--output-type=dart');
>       args.add ...
> 
> To make fallthrough work and avoid the if seems to require:
>   case 'a':
>     ...
>     continue b;
>   b: case 'b':
>     ...
> 
>       ...

Done.

Expand Messages | Collapse Messages