Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: llvm/lib/Target/X86/X86NaClRewritePass.cpp

Issue 10808110: Fix cases where fast instruction selection generated both base and index registers (Closed)
Patch Set: Conditionalize code based on nacl target Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « llvm/lib/Target/X86/X86FastISel.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: llvm/lib/Target/X86/X86NaClRewritePass.cpp
===================================================================
--- a/llvm/lib/Target/X86/X86NaClRewritePass.cpp
+++ b/llvm/lib/Target/X86/X86NaClRewritePass.cpp
@@ -536,9 +536,23 @@
assert(Scale.getImm() == 1);
AddrReg = 0;
} else {
- assert(!BaseReg.getReg() && "Unexpected relative register pair");
- BaseReg.setReg(UseZeroBasedSandbox ? 0 : X86::R15);
- AddrReg = IndexReg.getReg();
+ if (!BaseReg.getReg()) {
+ // No base, fill in relative.
+ BaseReg.setReg(UseZeroBasedSandbox ? 0 : X86::R15);
+ AddrReg = IndexReg.getReg();
+ } else if (!UseZeroBasedSandbox) {
+ // Switch base and index registers if index register is undefined.
+ // That is do conversions like "mov d(%r,0,0) -> mov d(%r15, %r, 1)".
+ assert (!IndexReg.getReg()
+ && "Unexpected index and base register");
+ IndexReg.setReg(BaseReg.getReg());
+ Scale.setImm(1);
+ BaseReg.setReg(X86::R15);
+ AddrReg = IndexReg.getReg();
+ } else {
+ llvm_unreachable(
+ "Unexpected index and base register");
+ }
}
if (AddrReg) {
« no previous file with comments | « llvm/lib/Target/X86/X86FastISel.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698