Fix position of web notification bubble and arrow

ui/views/bubble/bubble_delegate.cc

Index: ui/views/bubble/bubble_delegate.cc
diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc
index 446b7b2de96529417a23c4e1c73570ba8ed29443..286efdcf00dc68e80c357b931aa1c544b3d3b8cd 100644
--- a/ui/views/bubble/bubble_delegate.cc
+++ b/ui/views/bubble/bubble_delegate.cc
@@ -181,7 +181,18 @@ View* BubbleDelegateView::GetContentsView() {
 
 NonClientFrameView* BubbleDelegateView::CreateNonClientFrameView(
     Widget* widget) {
-  return new BubbleFrameView(arrow_location(), color(), margins());
+  BubbleFrameView* frame_view = new BubbleFrameView(margins());

[msw, 2012/07/23 22:20:49]

What's wrong with the current construction pattern?

+  BubbleBorder::ArrowLocation arrow_loc = arrow_location();
+  if (base::i18n::IsRTL())
+    arrow_loc = BubbleBorder::horizontal_mirror(arrow_loc);

[msw, 2012/07/23 22:20:49]

Why add this new arrow mirroring here?

[stevenjb, 2012/07/23 23:32:06]

This was previously in the constructor.

+  // TODO(alicet): Expose the shadow option in BorderContentsView when we make
+  // the fullscreen exit bubble use the new bubble code.
+  BubbleBorder* bubble_border =
+      new BubbleBorder(arrow_loc, BubbleBorder::NO_SHADOW);
+  bubble_border->set_background_color(color());
+  frame_view->SetBubbleBorder(bubble_border);
+  frame_view->set_background(new BubbleBackground(bubble_border));
+  return frame_view;
 }
 
 void BubbleDelegateView::OnWidgetClosing(Widget* widget) {