Fix position of web notification bubble and arrow

ui/views/bubble/bubble_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_delegate.h"
 
 #include "ui/base/animation/slide_animation.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/views/bubble/bubble_frame_view.h"
 #include "ui/views/widget/widget.h"
@@ skipping 163 matching lines @@
 BubbleDelegateView* BubbleDelegateView::AsBubbleDelegate() {
   return this;
 }
 
 View* BubbleDelegateView::GetContentsView() {
   return this;
 }
 
 NonClientFrameView* BubbleDelegateView::CreateNonClientFrameView(
     Widget* widget) {
-  return new BubbleFrameView(arrow_location(), color(), margins());
+  BubbleFrameView* frame_view = new BubbleFrameView(margins());

[msw, 2012/07/23 22:20:49]

What's wrong with the current construction pattern?

+  BubbleBorder::ArrowLocation arrow_loc = arrow_location();
+  if (base::i18n::IsRTL())
+    arrow_loc = BubbleBorder::horizontal_mirror(arrow_loc);

[msw, 2012/07/23 22:20:49]

Why add this new arrow mirroring here?

[stevenjb, 2012/07/23 23:32:06]

This was previously in the constructor.

+  // TODO(alicet): Expose the shadow option in BorderContentsView when we make
+  // the fullscreen exit bubble use the new bubble code.
+  BubbleBorder* bubble_border =
+      new BubbleBorder(arrow_loc, BubbleBorder::NO_SHADOW);
+  bubble_border->set_background_color(color());
+  frame_view->SetBubbleBorder(bubble_border);
+  frame_view->set_background(new BubbleBackground(bubble_border));
+  return frame_view;
 }
 
 void BubbleDelegateView::OnWidgetClosing(Widget* widget) {
   if (anchor_widget() == widget) {
     anchor_view_ = NULL;
     anchor_widget_ = NULL;
   }
 }
 
 void BubbleDelegateView::OnWidgetVisibilityChanged(Widget* widget,
@@ skipping 132 matching lines @@
 
 #if defined(OS_WIN) && !defined(USE_AURA)
 gfx::Rect BubbleDelegateView::GetBubbleClientBounds() const {
   gfx::Rect client_bounds(GetBubbleFrameView()->GetBoundsForClientView());
   client_bounds.Offset(border_widget_->GetWindowBoundsInScreen().origin());
   return client_bounds;
 }
 #endif
 
 }  // namespace views