Fix position of web notification bubble and arrow

ui/views/bubble/bubble_border.h

Index: ui/views/bubble/bubble_border.h
diff --git a/ui/views/bubble/bubble_border.h b/ui/views/bubble/bubble_border.h
index cc15f2bea4775a487ee8172b2a246a70e859e3aa..6912fd91e8d5cd549f1e536ba04f868b68f94af6 100644
--- a/ui/views/bubble/bubble_border.h
+++ b/ui/views/bubble/bubble_border.h
@@ -123,6 +123,12 @@ class VIEWS_EXPORT BubbleBorder : public Border {
  protected:
   virtual ~BubbleBorder();
 
+  // Specifies the arrow location for calculating insets (for rtl mirroring).

[msw, 2012/07/23 22:20:49]

I don't understand this comment, nor do I see why this function is worthwhile.

[stevenjb, 2012/07/23 23:32:06]

It gets used in ash::TrayBubbleBorder::Paint. I can try to clarify the comment,
but basically it allows that code to get the correct insets without the extra
mirroring.

[msw, 2012/07/24 00:32:44]

Hmm, hopefully we'll end up with a single point of truth for the RTL arrow
mirroring and resulting Insets and this won't be needed.

+  void GetInsetsForArrowLocation(gfx::Insets* insets,
+                                 ArrowLocation arrow_loc) const;
+
+  void set_rtl_mirrored(bool mirrored) { rtl_mirrored_ = mirrored; }
+
  private:
   struct BorderImages;
 
@@ -166,6 +172,9 @@ class VIEWS_EXPORT BubbleBorder : public Border {
   // TODO(msw): Clean this up when Windows native controls are no longer needed.
   gfx::Rect client_bounds_;
 
+  // Set this to false avoid mirroring insets for RTL rendering.
+  bool rtl_mirrored_;

[msw, 2012/07/23 22:20:49]

nit: rename for clarity |mirror_in_rtl_| (or similar); specify default value.

[stevenjb, 2012/07/26 23:48:30]

Removed this and orverrode SetBounds() instead, moving logic to TrayBubbleView.

+
   DISALLOW_COPY_AND_ASSIGN(BubbleBorder);
 };