Fix position of web notification bubble and arrow

ui/views/bubble/bubble_border.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "ui/views/background.h"
@@ skipping 105 matching lines @@
 
   // Overridden from Border:
   virtual void GetInsets(gfx::Insets* insets) const OVERRIDE;
 
   // How many pixels the bubble border is from the edge of the images.
   int border_thickness() const;
 
  protected:
   virtual ~BubbleBorder();
 
+  // Specifies the arrow location for calculating insets (for rtl mirroring).

[msw, 2012/07/23 22:20:49]

I don't understand this comment, nor do I see why this function is worthwhile.

[stevenjb, 2012/07/23 23:32:06]

It gets used in ash::TrayBubbleBorder::Paint. I can try to clarify the comment,
but basically it allows that code to get the correct insets without the extra
mirroring.

[msw, 2012/07/24 00:32:44]

Hmm, hopefully we'll end up with a single point of truth for the RTL arrow
mirroring and resulting Insets and this won't be needed.

+  void GetInsetsForArrowLocation(gfx::Insets* insets,
+                                 ArrowLocation arrow_loc) const;
+
+  void set_rtl_mirrored(bool mirrored) { rtl_mirrored_ = mirrored; }
+
  private:
   struct BorderImages;
 
   // Loads images if necessary.
   static BorderImages* GetBorderImages(Shadow shadow);
 
   // Overridden from Border:
   virtual void Paint(const View& view,
                      gfx::Canvas* canvas) const OVERRIDE;
 
@@ skipping 23 matching lines @@
   int override_arrow_offset_;
 
   ArrowLocation arrow_location_;
   BubbleAlignment alignment_;
   SkColor background_color_;
 
   // The client/content bounds; must be clipped from the background on Windows.
   // TODO(msw): Clean this up when Windows native controls are no longer needed.
   gfx::Rect client_bounds_;
 
+  // Set this to false avoid mirroring insets for RTL rendering.
+  bool rtl_mirrored_;

[msw, 2012/07/23 22:20:49]

nit: rename for clarity |mirror_in_rtl_| (or similar); specify default value.

[stevenjb, 2012/07/26 23:48:30]

Removed this and orverrode SetBounds() instead, moving logic to TrayBubbleView.

+
   DISALLOW_COPY_AND_ASSIGN(BubbleBorder);
 };
 
 // A Background that clips itself to the specified BubbleBorder and uses
 // the background color of the BubbleBorder.
 class VIEWS_EXPORT BubbleBackground : public Background {
  public:
   explicit BubbleBackground(BubbleBorder* border) : border_(border) {}
 
   // Overridden from Background:
   virtual void Paint(gfx::Canvas* canvas, View* view) const OVERRIDE;
 
  private:
   BubbleBorder* border_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleBackground);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_BORDER_H_