Change the navigation code of sync promo slightly to navigate

chrome/browser/ui/webui/sync_promo/sync_promo_ui.h

Index: chrome/browser/ui/webui/sync_promo/sync_promo_ui.h
===================================================================
--- chrome/browser/ui/webui/sync_promo/sync_promo_ui.h	(revision 147566)
+++ chrome/browser/ui/webui/sync_promo/sync_promo_ui.h	(working copy)
@@ -17,6 +17,7 @@
     SOURCE_START_PAGE = 0, // This must be first.
     SOURCE_NTP_LINK,
     SOURCE_MENU,
+    SOURCE_EXTENSION_API,

[sail, 2012/07/20 22:43:45]

Are you planning to use this later? I don't see a reference to this anywhere in
this CL.

Also, this enum is used to collect some UMA data. You'll have to also update
this code:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/ui/webui/sy...
and the SyncPromoShowAndSignIn enum in tools/histogram/histograms.xml

[Munjal (Google), 2012/07/20 23:04:35]

Yeah, I am using it in a different patch. But actually let me add this in a
separate CL to keep this patch focused.

     SOURCE_UNKNOWN, // This must be last.
   };
 
@@ -52,7 +53,11 @@
   // promo. If an empty URL is given then the promo will navigate to the NTP.
   // |source| identifies from where the sync promo is being called, and is used
   // to record sync promo UMA stats in the context of the source.
+  // |auto_close| whether to close the sync promo automatically when done.
+  // Default is false.
   static GURL GetSyncPromoURL(const GURL& next_page, Source source);
+  static GURL GetSyncPromoURL(

[sail, 2012/07/20 22:43:45]

I don't think it's worth overloading this function. you can just add auto_close
to the original function

[Munjal (Google), 2012/07/20 23:04:35]

Done.

+      const GURL& next_page, Source source, bool auto_close);
 
   // Gets the next page URL from the query portion of the sync promo URL.
   static GURL GetNextPageURLForSyncPromoURL(const GURL& url);
@@ -61,6 +66,9 @@
   // The source identifies from where the sync promo was opened.
   static Source GetSourceForSyncPromoURL(const GURL& url);
 
+  // Returns whether the given sync URL contains auto_close parameter.
+  static bool GetAutoCloseForSyncPromoURL(const GURL& url);
+
  private:
   DISALLOW_COPY_AND_ASSIGN(SyncPromoUI);
 };