Change the navigation code of sync promo slightly to navigate

chrome/browser/ui/webui/sync_promo/sync_promo_ui.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_SYNC_PROMO_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_SYNC_PROMO_UI_H_
 
 #include "content/public/browser/web_ui_controller.h"
 
 class Profile;
 class PrefService;
 
 // The Web UI handler for chrome://signin.
 class SyncPromoUI : public content::WebUIController {
  public:
   enum Source {
     SOURCE_START_PAGE = 0, // This must be first.
     SOURCE_NTP_LINK,
     SOURCE_MENU,
+    SOURCE_EXTENSION_API,

[sail, 2012/07/20 22:43:45]

Are you planning to use this later? I don't see a reference to this anywhere in
this CL.

Also, this enum is used to collect some UMA data. You'll have to also update
this code:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/ui/webui/sy...
and the SyncPromoShowAndSignIn enum in tools/histogram/histograms.xml

[Munjal (Google), 2012/07/20 23:04:35]

Yeah, I am using it in a different patch. But actually let me add this in a
separate CL to keep this patch focused.

     SOURCE_UNKNOWN, // This must be last.
   };
 
   // Constructs a SyncPromoUI.
   explicit SyncPromoUI(content::WebUI* web_ui);
 
   // Returns true if the sync promo should be visible.
   // |profile| is the profile of the tab the promo would be shown on.
   static bool ShouldShowSyncPromo(Profile* profile);
 
@@ skipping 15 matching lines @@
   static void SetUserSkippedSyncPromo(Profile* profile);
 
   // Registers the preferences the Sync Promo UI needs.
   static void RegisterUserPrefs(PrefService* prefs);
 
   // Returns the sync promo URL wth the given arguments in the query.
   // |next_page| is the URL to navigate to when the user completes or skips the
   // promo. If an empty URL is given then the promo will navigate to the NTP.
   // |source| identifies from where the sync promo is being called, and is used
   // to record sync promo UMA stats in the context of the source.
+  // |auto_close| whether to close the sync promo automatically when done.
+  // Default is false.
   static GURL GetSyncPromoURL(const GURL& next_page, Source source);
+  static GURL GetSyncPromoURL(

[sail, 2012/07/20 22:43:45]

I don't think it's worth overloading this function. you can just add auto_close
to the original function

[Munjal (Google), 2012/07/20 23:04:35]

Done.

+      const GURL& next_page, Source source, bool auto_close);
 
   // Gets the next page URL from the query portion of the sync promo URL.
   static GURL GetNextPageURLForSyncPromoURL(const GURL& url);
 
   // Gets the source from the query portion of the sync promo URL.
   // The source identifies from where the sync promo was opened.
   static Source GetSourceForSyncPromoURL(const GURL& url);
 
+  // Returns whether the given sync URL contains auto_close parameter.
+  static bool GetAutoCloseForSyncPromoURL(const GURL& url);
+
  private:
   DISALLOW_COPY_AND_ASSIGN(SyncPromoUI);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_SYNC_PROMO_UI_H_