Kill DownloadItem::IsOtr()

chrome/browser/automation/automation_provider.cc

Index: chrome/browser/automation/automation_provider.cc
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc
index b2ea3ffbe87eca76a9d9f338c01c1281cd62b9a3..37bc48925fe64478b8ccce1242f72049139b2802 100644
--- a/chrome/browser/automation/automation_provider.cc
+++ b/chrome/browser/automation/automation_provider.cc
@@ -300,7 +300,7 @@ int AutomationProvider::GetIndexForNavigationController(
 
 // TODO(phajdan.jr): move to TestingAutomationProvider.
 DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(
-    const DownloadItem* download) {
+    const DownloadItem* download, bool incognito) {
   std::map<DownloadItem::DownloadState, std::string> state_to_string;
   state_to_string[DownloadItem::IN_PROGRESS] = std::string("IN_PROGRESS");
   state_to_string[DownloadItem::CANCELLED] = std::string("CANCELLED");
@@ -326,7 +326,7 @@ DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(
   dl_item_value->SetBoolean("open_when_complete",
                             download->GetOpenWhenComplete());
   dl_item_value->SetBoolean("is_temporary", download->IsTemporary());
-  dl_item_value->SetBoolean("is_otr", download->IsOtr());  // incognito
+  dl_item_value->SetBoolean("is_otr", incognito);

[Randy Smith (Not in Mondays), 2012/07/23 18:19:26]

Does this interface make sense, or would it make more sense to project upwards
to consumers of this interface what download manager/profile the download item
comes from?  I haven't looked at the consumer requirements, but having an
argument that's passed in to directly tweak an output value feels wrong at the
producer level--the work of this routine is converting DownloadItem into a
different form.

   dl_item_value->SetString("state", state_to_string[download->GetState()]);
   dl_item_value->SetString("safety_state",
                            safety_state_to_string[download->GetSafetyState()]);