Kill DownloadItem::IsOtr()

chrome/browser/automation/automation_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/automation_provider.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 282 matching lines @@
 }
 
 int AutomationProvider::GetIndexForNavigationController(
     const NavigationController* controller, const Browser* parent) const {
   DCHECK(parent);
   return chrome::GetIndexOfTab(parent, controller->GetWebContents());
 }
 
 // TODO(phajdan.jr): move to TestingAutomationProvider.
 DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(
-    const DownloadItem* download) {
+    const DownloadItem* download, bool incognito) {
   std::map<DownloadItem::DownloadState, std::string> state_to_string;
   state_to_string[DownloadItem::IN_PROGRESS] = std::string("IN_PROGRESS");
   state_to_string[DownloadItem::CANCELLED] = std::string("CANCELLED");
   state_to_string[DownloadItem::REMOVING] = std::string("REMOVING");
   state_to_string[DownloadItem::INTERRUPTED] = std::string("INTERRUPTED");
   state_to_string[DownloadItem::COMPLETE] = std::string("COMPLETE");
 
   std::map<DownloadItem::SafetyState, std::string> safety_state_to_string;
   safety_state_to_string[DownloadItem::SAFE] = std::string("SAFE");
   safety_state_to_string[DownloadItem::DANGEROUS] = std::string("DANGEROUS");
   safety_state_to_string[DownloadItem::DANGEROUS_BUT_VALIDATED] =
       std::string("DANGEROUS_BUT_VALIDATED");
 
   DictionaryValue* dl_item_value = new DictionaryValue;
   dl_item_value->SetInteger("id", static_cast<int>(download->GetId()));
   dl_item_value->SetString("url", download->GetURL().spec());
   dl_item_value->SetString("referrer_url", download->GetReferrerUrl().spec());
   dl_item_value->SetString("file_name",
                            download->GetFileNameToReportUser().value());
   dl_item_value->SetString("full_path",
                            download->GetTargetFilePath().value());
   dl_item_value->SetBoolean("is_paused", download->IsPaused());
   dl_item_value->SetBoolean("open_when_complete",
                             download->GetOpenWhenComplete());
   dl_item_value->SetBoolean("is_temporary", download->IsTemporary());
-  dl_item_value->SetBoolean("is_otr", download->IsOtr());  // incognito
+  dl_item_value->SetBoolean("is_otr", incognito);

[Randy Smith (Not in Mondays), 2012/07/23 18:19:26]

Does this interface make sense, or would it make more sense to project upwards
to consumers of this interface what download manager/profile the download item
comes from?  I haven't looked at the consumer requirements, but having an
argument that's passed in to directly tweak an output value feels wrong at the
producer level--the work of this routine is converting DownloadItem into a
different form.

   dl_item_value->SetString("state", state_to_string[download->GetState()]);
   dl_item_value->SetString("safety_state",
                            safety_state_to_string[download->GetSafetyState()]);
   dl_item_value->SetInteger("PercentComplete", download->PercentComplete());
 
   return dl_item_value;
 }
 
 void AutomationProvider::OnChannelConnected(int pid) {
   is_connected_ = true;
@@ skipping 410 matching lines @@
 
   return NULL;
 }
 
 void AutomationProvider::SaveAsAsync(int tab_handle) {
   NavigationController* tab = NULL;
   WebContents* web_contents = GetWebContentsForHandle(tab_handle, &tab);
   if (web_contents)
     web_contents->OnSavePage();
 }