Fix TCPClientSocket::GetLocalAddress() to work when socket is not connected.

net/socket/tcp_client_socket_unittest.cc

Index: net/socket/tcp_client_socket_unittest.cc
diff --git a/net/socket/tcp_client_socket_unittest.cc b/net/socket/tcp_client_socket_unittest.cc
index c2589b81923a0922c44fd38633249b17205f05cf..3375173bf73f15dbca143ab29ec36c8bbc23297c 100644
--- a/net/socket/tcp_client_socket_unittest.cc
+++ b/net/socket/tcp_client_socket_unittest.cc
@@ -34,6 +34,10 @@ TEST(TCPClientSocketTest, BindLoopbackToLoopback) {
 
   EXPECT_EQ(OK, socket.Bind(IPEndPoint(lo_address, 0)));
 
+  IPEndPoint local_address_result;
+  EXPECT_EQ(OK, socket.GetLocalAddress(&local_address_result));
+  EXPECT_EQ(lo_address, local_address_result.address());
+
   TestCompletionCallback connect_callback;
   EXPECT_EQ(ERR_IO_PENDING, socket.Connect(connect_callback.callback()));
 
@@ -45,6 +49,11 @@ TEST(TCPClientSocketTest, BindLoopbackToLoopback) {
   ASSERT_EQ(OK, result);
 
   EXPECT_EQ(OK, connect_callback.WaitForResult());
+
+  socket.Disconnect();

[wtc, 2012/07/19 22:39:26]

Thank you for adding this test.

Ideally we should add the following test before this test:

  EXPECT_TRUE(socket.IsConnected());
  accepted_socket->Disconnect();
  EXPECT_FALSE(socket.IsConnected());  // MAY NEED TO REMOVE THIS BECAUSE IT MAY
BE FLAKY
  EXPECT_EQ(OK, socket.GetLocalAddress(&local_address_result));

[Sergey Ulanov, 2012/07/19 23:48:48]

Done.

+  EXPECT_FALSE(socket.IsConnected());

[wtc, 2012/07/19 22:39:26]

Here ideally we want to test that the internal socket_ member
is INVALID_SOCKET, but there may not be a public method to test
that.  So checking that socket.IsConnected() is false
may be the best we can do.

+  EXPECT_EQ(ERR_SOCKET_NOT_CONNECTED,
+            socket.GetLocalAddress(&local_address_result));
 }
 
 // Try to bind socket to the loopback interface and connect to an