Fix TCPClientSocket::GetLocalAddress() to work when socket is not connected.

net/socket/tcp_client_socket_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains some tests for TCPClientSocket.
 // transport_client_socket_unittest.cc contans some other tests that
 // are common for TCP and other types of sockets.
 
 #include "net/socket/tcp_client_socket.h"
 
@@ skipping 16 matching lines @@
 
   TCPServerSocket server(NULL, NetLog::Source());
   ASSERT_EQ(OK, server.Listen(IPEndPoint(lo_address, 0), 1));
   IPEndPoint server_address;
   ASSERT_EQ(OK, server.GetLocalAddress(&server_address));
 
   TCPClientSocket socket(AddressList(server_address), NULL, NetLog::Source());
 
   EXPECT_EQ(OK, socket.Bind(IPEndPoint(lo_address, 0)));
 
+  IPEndPoint local_address_result;
+  EXPECT_EQ(OK, socket.GetLocalAddress(&local_address_result));
+  EXPECT_EQ(lo_address, local_address_result.address());
+
   TestCompletionCallback connect_callback;
   EXPECT_EQ(ERR_IO_PENDING, socket.Connect(connect_callback.callback()));
 
   TestCompletionCallback accept_callback;
   scoped_ptr<StreamSocket> accepted_socket;
   int result = server.Accept(&accepted_socket, accept_callback.callback());
   if (result == ERR_IO_PENDING)
     result = accept_callback.WaitForResult();
   ASSERT_EQ(OK, result);
 
   EXPECT_EQ(OK, connect_callback.WaitForResult());
+
+  socket.Disconnect();

[wtc, 2012/07/19 22:39:26]

Thank you for adding this test.

Ideally we should add the following test before this test:

  EXPECT_TRUE(socket.IsConnected());
  accepted_socket->Disconnect();
  EXPECT_FALSE(socket.IsConnected());  // MAY NEED TO REMOVE THIS BECAUSE IT MAY
BE FLAKY
  EXPECT_EQ(OK, socket.GetLocalAddress(&local_address_result));

[Sergey Ulanov, 2012/07/19 23:48:48]

Done.

+  EXPECT_FALSE(socket.IsConnected());

[wtc, 2012/07/19 22:39:26]

Here ideally we want to test that the internal socket_ member
is INVALID_SOCKET, but there may not be a public method to test
that.  So checking that socket.IsConnected() is false
may be the best we can do.

+  EXPECT_EQ(ERR_SOCKET_NOT_CONNECTED,
+            socket.GetLocalAddress(&local_address_result));
 }
 
 // Try to bind socket to the loopback interface and connect to an
 // external address, verify that connection fails.
 TEST(TCPClientSocketTest, BindLoopbackToExternal) {
   IPAddressNumber external_ip;
   ASSERT_TRUE(ParseIPLiteralToNumber("72.14.213.105", &external_ip));
   TCPClientSocket socket(AddressList::CreateFromIPAddress(external_ip, 80),
                          NULL, NetLog::Source());
 
@@ skipping 36 matching lines @@
   int result = socket.Connect(connect_callback.callback());
   if (result == ERR_IO_PENDING)
     result = connect_callback.WaitForResult();
 
   EXPECT_NE(OK, result);
 }
 
 }  // namespace
 
 }  // namespace net