Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 10800093: pageNumerForElementById is a test specific API and can be moved to window.internals (Closed)

Created:
8 years, 5 months ago by silverroots-g
Modified:
8 years, 4 months ago
Reviewers:
jamesr, tony
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

pageNumerForElementById is a test specific API and can be moved to window.internals Bug=138710 No New tests.

Patch Set 1 #

Patch Set 2 : pageNumerForElementById is a test specific API and can be moved to window.internals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
silverroots-g
The corresponding webkit bug is - https://bugs.webkit.org/show_bug.cgi?id=92091
8 years, 5 months ago (2012-07-24 13:17:12 UTC) #1
abarth-chromium
LGTM (I am not an OWNER)
8 years, 5 months ago (2012-07-24 17:33:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaustubh.ra@gmail.com/10800093/1
8 years, 5 months ago (2012-07-25 06:00:22 UTC) #3
commit-bot: I haz the power
Presubmit check for 10800093-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-25 06:00:24 UTC) #4
silverroots-g
pageNumerForElementById is a test specific API and can be moved to window.internals Bug=138710 No New ...
8 years, 5 months ago (2012-07-25 14:17:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaustubh.ra@gmail.com/10800093/5002
8 years, 5 months ago (2012-07-26 07:12:21 UTC) #6
commit-bot: I haz the power
Presubmit check for 10800093-5002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-26 07:12:24 UTC) #7
Hajime Morrita
Tony, James, could you rubberstamp this?
8 years, 5 months ago (2012-07-26 07:19:28 UTC) #8
tony
LGTM
8 years, 5 months ago (2012-07-26 17:30:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaustubh.ra@gmail.com/10800093/5002
8 years, 5 months ago (2012-07-26 18:28:33 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 19:41:58 UTC) #11
Change committed as 148610

Powered by Google App Engine
This is Rietveld 408576698