Debugger API to enable/disable debugging of libraries

Debugger API to enable/disable debugging of libraries
Committed: https://code.google.com/p/dart/source/detail?r=9772

[regis, 2012-07-19 20:40:57]

LGTM with comments.

Also, how did you manage to get codereview.chromium.org instead of the usual
chromiumcodereview.appspot.com in your codereview urls? This caused me weird
login issues.

Thanks,
Regis

http://codereview.chromium.org/10797033/diff/1/runtime/bin/dbg_connection.cc
File runtime/bin/dbg_connection.cc (right):

http://codereview.chromium.org/10797033/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:547: bool is_debuggable= false;
missing space

http://codereview.chromium.org/10797033/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:846: } else if (strcmp(enable_request, "true")) {
You probably mean
 } else if (strcmp(enable_request, "false") == 0) {

http://codereview.chromium.org/10797033/diff/1/tools/ddbg.dart
File tools/ddbg.dart (right):

http://codereview.chromium.org/10797033/diff/1/tools/ddbg.dart#newcode141
tools/ddbg.dart:141: } else if (command == "slib" && args.length == 3) {
This source file is not following our (C++) style guide. I guess we do not
require parentheses in Dart sources as we do in C++ sources?

[hausner, 2012-07-19 22:50:35]

Thank you!

http://codereview.chromium.org/10797033/diff/1/runtime/bin/dbg_connection.cc
File runtime/bin/dbg_connection.cc (right):

http://codereview.chromium.org/10797033/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:547: bool is_debuggable= false;
On 2012/07/19 20:40:57, regis wrote:
> missing space

Done.

http://codereview.chromium.org/10797033/diff/1/runtime/bin/dbg_connection.cc#...
runtime/bin/dbg_connection.cc:846: } else if (strcmp(enable_request, "true")) {
On 2012/07/19 20:40:57, regis wrote:
> You probably mean
>  } else if (strcmp(enable_request, "false") == 0) {

Yes. Ironically my faulty code also works if the input is "false": strcmp
returns non-null and the branch is taken. That's why my manual testing with
"true" and "false" worked... Nice catch!

http://codereview.chromium.org/10797033/diff/1/tools/ddbg.dart
File tools/ddbg.dart (right):

http://codereview.chromium.org/10797033/diff/1/tools/ddbg.dart#newcode141
tools/ddbg.dart:141: } else if (command == "slib" && args.length == 3) {
On 2012/07/19 20:40:57, regis wrote:
> This source file is not following our (C++) style guide. I guess we do not
> require parentheses in Dart sources as we do in C++ sources?
I don't see anything in the style guide that requires them. And I hope we don't
add it :-)