Issue 10795024: ui: Forward declare DefaultSingletonTraits in header files.

Issue 10795024: ui: Forward declare DefaultSingletonTraits in header files. (Closed)

Created:
8 years, 5 months ago by tfarina

Modified:
8 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui: Forward declare DefaultSingletonTraits in header files. Prefer forward declarations in header files, and instead include the singleton.h in the source file. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147660

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -18 lines)			Patch
M	ui/base/gtk/g_object_destructor_filo.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	ui/base/gtk/g_object_destructor_filo.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/base/gtk/gdk_x_compat.h	View		1 chunk	+2 lines, -1 line	1 comment	Download
M	ui/base/touch/touch_factory.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/touch/touch_factory.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/x/active_window_watcher_x.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/x/active_window_watcher_x.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/base/x/events_x.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/x/root_window_property_watcher_x.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/x/root_window_property_watcher_x.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/x/valuators.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/base/x/valuators.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/x/work_area_watcher_x.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/base/x/work_area_watcher_x.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/gtk_native_view_id_manager.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gfx/gtk_native_view_id_manager.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/views/focus/view_storage.h	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
M	ui/views/focus/view_storage.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/x11_desktop_handler.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/widget/x11_desktop_handler.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/10795024/diff/8003/ui/base/gtk/gdk_x_compat.h File ui/base/gtk/gdk_x_compat.h (right): http://codereview.chromium.org/10795024/diff/8003/ui/base/gtk/gdk_x_compat.h#newcode8 ui/base/gtk/gdk_x_compat.h:8: #include <gtk/gtk.h> Why the gtk include here? All the ...

8 years, 5 months ago (2012-07-19 16:09:02 UTC) #2

tfarina

On Thursday, July 19, 2012, wrote: > > http://codereview.chromium.**org/10795024/diff/8003/ui/** > base/gtk/gdk_x_compat.h<http://codereview.chromium.org/10795024/diff/8003/ui/base/gtk/gdk_x_compat.h> > File ui/base/gtk/gdk_x_compat.h (right): ...

8 years, 5 months ago (2012-07-19 16:10:34 UTC) #3

LGTM

Expand Messages | Collapse Messages