Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1079012: Fix pop push optimization to work with partial snapshots (correct... (Closed)

Created:
10 years, 9 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix pop push optimization to work with partial snapshots (correct registration of external references in Proxy objects). I moved the declaration of the two functions to stub-cache.h because with all the types they use it's hard to declare them anywhere else. But the actual definition is still in runtime.cc near to the place where they are used. Committed: http://code.google.com/p/v8/source/detail?r=4231

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -32 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 2 chunks +4 lines, -0 lines 1 comment Download
M src/assembler.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 4 chunks +20 lines, -17 lines 0 comments Download
M src/serialize.cc View 1 chunk +15 lines, -7 lines 0 comments Download
M src/stub-cache.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 9 months ago (2010-03-23 14:24:51 UTC) #1
Kasper Lund
10 years, 9 months ago (2010-03-23 14:27:52 UTC) #2
LGTM!

http://codereview.chromium.org/1079012/diff/1/6
File src/assembler.h (right):

http://codereview.chromium.org/1079012/diff/1/6#newcode509
src/assembler.h:509: 
Intentional edit?

Powered by Google App Engine
This is Rietveld 408576698