Fix pop push optimization to work with partial snapshots (correct...

src/assembler.h

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 425 matching lines @@
 
   static ExternalReference double_fp_operation(Token::Value operation);
   static ExternalReference compare_doubles();
 
   static ExternalReference handle_scope_extensions_address();
   static ExternalReference handle_scope_next_address();
   static ExternalReference handle_scope_limit_address();
 
   static ExternalReference scheduled_exception_address();
 
+  static ExternalReference compile_array_pop_call();
+  static ExternalReference compile_array_push_call();
+
   Address address() const {return reinterpret_cast<Address>(address_);}
 
 #ifdef ENABLE_DEBUGGER_SUPPORT
   // Function Debug::Break()
   static ExternalReference debug_break();
 
   // Used to check if single stepping is enabled in generated code.
   static ExternalReference debug_step_in_fp_address();
 #endif
 
@@ skipping 40 matching lines @@
                    (*redirector_)(address, fp_return);
     return answer;
   }
 
   void* address_;
 };
 
 
 // -----------------------------------------------------------------------------
 // Utility functions
 

[Kasper Lund, 2010/03/23 14:27:52]

Intentional edit?

+
 static inline bool is_intn(int x, int n)  {
   return -(1 << (n-1)) <= x && x < (1 << (n-1));
 }
 
 static inline bool is_int8(int x)  { return is_intn(x, 8); }
 static inline bool is_int16(int x)  { return is_intn(x, 16); }
 static inline bool is_int18(int x)  { return is_intn(x, 18); }
 static inline bool is_int24(int x)  { return is_intn(x, 24); }
 
 static inline bool is_uintn(int x, int n) {
@@ skipping 17 matching lines @@
   unsigned int num_bits_set;
   for (num_bits_set = 0; x; x >>= 1) {
     num_bits_set += x & 1;
   }
   return num_bits_set;
 }
 
 } }  // namespace v8::internal
 
 #endif  // V8_ASSEMBLER_H_